Skip to content

docs: sync country coverage with corridor source of truth#472

Merged
pengying merged 2 commits into
mainfrom
claude/laughing-gauss-de7efe
May 18, 2026
Merged

docs: sync country coverage with corridor source of truth#472
pengying merged 2 commits into
mainfrom
claude/laughing-gauss-de7efe

Conversation

@pengying
Copy link
Copy Markdown
Contributor

Summary

Reconcile the mintlify country coverage docs with the Grid Switch Corridor List tab of the country coverage timeline sheet.

  • Add 🇨🇴 Colombia (CO, Bank Transfer) to the live country list — sheet shows LSP US → Colombia / COP / Thunes as Live (5/15/2026).
  • Bump the Americas regional summary from 3 → 4 countries.
  • Remove 🇰🇷 South Korea from "Coming Soon" — no longer present in the corridor list.

Notes

  • The "Public Roadmap" column is in the sheet but was not retrievable via the Google Drive natural-language export used in this run (the export collapses wide tables and that column was dropped). Coming Soon entries already in the doc that are still present in the corridor list as non-Live (Canada, China, Hong Kong) were left in place. Other Scoping / H1 2026 Plan / Blocked corridors in the sheet (e.g. Egypt, Guatemala, Honduras, Morocco, El Salvador, Pakistan, Haiti, Ghana, Nepal, Ethiopia, Dominican Republic, etc.) were not added because Public Roadmap = Yes could not be confirmed for them. A follow-up with direct sheet access can finish the Coming Soon sync.

Test plan

  • make lint-openapi passes (markdown changes only)
  • Visual check that Colombia appears in alphabetical order between Cameroon and Croatia
  • Regional summary tag reads "4 countries" for Americas
  • Coming Soon table no longer includes South Korea

🤖 Generated with Claude Code

pengying and others added 2 commits May 11, 2026 11:47
Some fee components are denominated in the receiving currency, so their
equivalent value in the sending currency moves with the FX rate between
quotes. Add a callout in the cross-currency send snippet and the Quote
System guide, and extend the OpenAPI descriptions on `feesIncluded`,
`OutgoingRateDetails`, and `IncomingRateDetails` so the same note shows
up in the API reference.
Reconcile mintlify country-support.mdx with the Grid Switch Corridor
List tab of the country coverage timeline sheet.

- Add Colombia (CO, Bank Transfer) to the live country list and bump
  the Americas regional count from 3 to 4
- Remove South Korea from the "Coming Soon" list (no longer present
  in the corridor list)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@mintlify
Copy link
Copy Markdown
Contributor

mintlify Bot commented May 18, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟢 Ready View Preview May 18, 2026, 7:18 PM

@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment May 18, 2026 7:17pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

chore(internal): regenerate SDK with no functional changes

csharp

docs(types): clarify fee currency handling in outgoing/incoming rate details and quotes

go

docs(types): clarify fee fluctuation in OutgoingRateDetails/IncomingRateDetails/Quote

kotlin

docs(types): document fee fluctuation in rate details and quote models

openapi

docs(types): update descriptions for IncomingRateDetails, OutgoingRateDetails, quote fees

php

docs(types): update fee calculation notes in quotes/transactions/webhooks

python

docs(types): clarify fee denomination in IncomingRateDetails/OutgoingRateDetails/Quote

ruby

docs: sync country coverage with corridor source of truth

typescript

docs(types): clarify fee fluctuation in quotes/transactions
⚠️ grid-openapi studio · code

Your SDK build had at least one warning diagnostic.
generate ✅

⚠️ grid-ruby studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ⚠️build ✅lint ❗test ✅

⚠️ grid-go studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ❗build ✅lint ❗test ❗

go get github.com/stainless-sdks/grid-go@afd45990ac11c0a7b2a74de0c16b463883a265a3
⚠️ grid-kotlin studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ✅build ✅lint ✅test ❗

⚠️ grid-python studio · code

Your SDK build had at least one warning diagnostic.
generate ✅build ✅lint ✅test ✅

pip install https://pkg.stainless.com/s/grid-python/72de174bd8012b3fa38c767f3ea0518856d41539/grid-0.0.1-py3-none-any.whl
⚠️ grid-csharp studio · code

Your SDK build had a failure in the build CI job, which is a regression from the base state.
generate ❗build ❗lint ❗test ❗

⚠️ grid-typescript studio · code

Your SDK build had a failure in the build CI job, which is a regression from the base state.
generate ✅build ❗lint ❗test ❗

⚠️ grid-php studio · code

Your SDK build had at least one "error" diagnostic.
generate ❗lint ✅test ✅

⚠️ grid-cli studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ⚠️build ⏭️lint ⏭️test ❗


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-05-18 22:51:27 UTC

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 18, 2026

Greptile Summary

This PR bundles two distinct doc changes: (1) syncing country coverage to add 🇨🇴 Colombia, bump the Americas regional count to 4, and drop South Korea from Coming Soon; and (2) adding fee-fluctuation callouts across the quote system conceptual docs, the cross-currency sending guide, and the OpenAPI schema descriptions for IncomingRateDetails, OutgoingRateDetails, and feesIncluded.

  • Country coverage: Colombia is inserted in correct alphabetical order between Cameroon and Croatia; the Americas FeatureCard tag and Coming Soon table are updated consistently.
  • Fee fluctuation docs: Clarifying notes are added in two MDX files and three OpenAPI schema descriptions. The same prose appears in both quote-system.mdx and cross-currency.mdx with slightly different wording \u2014 a shared snippet would keep them in sync.
  • Generated bundles: openapi.yaml and mintlify/openapi.yaml are updated in lockstep with their source files under openapi/components/schemas/, consistent with the make build workflow.

Confidence Score: 4/5

Safe to merge — all changes are documentation-only with no application logic.

The country coverage changes are straightforward and correctly applied. The fee-fluctuation note is duplicated across two MDX files with slightly diverging wording; if they drift further over time, readers in different journeys will see inconsistent guidance. The callout component choice (Note vs Warning) is also worth a second look given the adjacent Warning about quote expiration.

mintlify/snippets/sending/cross-currency.mdx — duplicate fee-fluctuation note and callout severity worth confirming before merge.

Important Files Changed

Filename Overview
mintlify/snippets/country-support.mdx Adds Colombia (CO) to the live country table in alphabetical order, bumps Americas regional count from 3 to 4, and removes South Korea from Coming Soon.
mintlify/platform-overview/core-concepts/quote-system.mdx Adds a Note callout about fee fluctuation between quotes, placed correctly after the fee calculation example. Wording is slightly more detailed than its counterpart in cross-currency.mdx.
mintlify/snippets/sending/cross-currency.mdx Adds a fee-fluctuation Note alongside the existing quote-expiration Warning. Nearly identical content also appears in quote-system.mdx with slightly different wording.
openapi/components/schemas/transactions/IncomingRateDetails.yaml Expands schema description to note that gridApiFixedFee is denominated in the receiving currency. Source file edited correctly.
openapi/components/schemas/transactions/OutgoingRateDetails.yaml Expands schema description to note that counterpartyFixedFee is denominated in the receiving currency. Source file edited correctly.
openapi/components/schemas/quotes/Quote.yaml Extends feesIncluded description with a note about cross-currency fee fluctuation. Clean multi-line YAML block scalar change.
openapi.yaml Generated bundle updated to reflect source schema changes; consistent with source edits.
mintlify/openapi.yaml Mintlify-side generated bundle updated in sync with root openapi.yaml.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Changes] --> B[Country Coverage]
    A --> C[Fee Fluctuation Docs]
    B --> B1[Add Colombia CO Bank Transfer]
    B --> B2[Americas count 3 to 4]
    B --> B3[Remove South Korea from Coming Soon]
    C --> C1[quote-system.mdx Note added]
    C --> C2[cross-currency.mdx Note added]
    C --> C3[OpenAPI Schema Descriptions]
    C3 --> D1[IncomingRateDetails.yaml]
    C3 --> D2[OutgoingRateDetails.yaml]
    C3 --> D3[Quote.yaml]
    D1 --> E[make build]
    D2 --> E
    D3 --> E
    E --> F1[openapi.yaml]
    E --> F2[mintlify/openapi.yaml]
Loading

Fix All in Claude Code

Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
mintlify/snippets/sending/cross-currency.mdx:93-99
The fee-fluctuation note here is nearly identical to the one added in `quote-system.mdx`, with slightly different wording (this one omits the specific field names `counterpartyFixedFee` / `gridApiFixedFee` that the other version mentions). Per the "use snippets instead of duplicating content" rule in CLAUDE.md, this content is a good candidate for a shared snippet — e.g. `mintlify/snippets/fee-fluctuation-note.mdx` — so both pages stay in sync automatically.

```suggestion
{/* Consider extracting to mintlify/snippets/fee-fluctuation-note.mdx and importing here */}
<Note>
  Quoted fees may fluctuate between quotes. Some underlying fee components
  are denominated in the receiving currency, so their equivalent in the
  sending currency moves with the FX rate. The fee shown in the quote is
  locked only for the lifetime of that quote — a new quote for the same
  transfer may return a different total.
</Note>
```

### Issue 2 of 2
mintlify/snippets/sending/cross-currency.mdx:89-97
**Consider `<Warning>` instead of `<Note>` for fee fluctuation**

The immediately preceding callout uses `<Warning>` for quote expiration, which simply causes a request to fail. The fee-fluctuation caveat can silently result in a different charge amount — a developer who doesn't account for it may show users a price that doesn't match the executed transfer. Per the AGENTS.md component guide, `<Warning>` is for "Critical information about potential issues"; this arguably qualifies more than expiration does. Consider promoting it to `<Warning>` for visual parity with the adjacent callout and to signal its importance.

Reviews (1): Last reviewed commit: "docs: sync country coverage with corrido..." | Re-trigger Greptile

Comment on lines +93 to +99
<Note>
Quoted fees may fluctuate between quotes. Some underlying fee components
are denominated in the receiving currency, so their equivalent in the
sending currency moves with the FX rate. The fee shown in the quote is
locked only for the lifetime of that quote — a new quote for the same
transfer may return a different total.
</Note>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The fee-fluctuation note here is nearly identical to the one added in quote-system.mdx, with slightly different wording (this one omits the specific field names counterpartyFixedFee / gridApiFixedFee that the other version mentions). Per the "use snippets instead of duplicating content" rule in CLAUDE.md, this content is a good candidate for a shared snippet — e.g. mintlify/snippets/fee-fluctuation-note.mdx — so both pages stay in sync automatically.

Suggested change
<Note>
Quoted fees may fluctuate between quotes. Some underlying fee components
are denominated in the receiving currency, so their equivalent in the
sending currency moves with the FX rate. The fee shown in the quote is
locked only for the lifetime of that quote — a new quote for the same
transfer may return a different total.
</Note>
{/* Consider extracting to mintlify/snippets/fee-fluctuation-note.mdx and importing here */}
<Note>
Quoted fees may fluctuate between quotes. Some underlying fee components
are denominated in the receiving currency, so their equivalent in the
sending currency moves with the FX rate. The fee shown in the quote is
locked only for the lifetime of that quote — a new quote for the same
transfer may return a different total.
</Note>

Context Used: CLAUDE.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/sending/cross-currency.mdx
Line: 93-99

Comment:
The fee-fluctuation note here is nearly identical to the one added in `quote-system.mdx`, with slightly different wording (this one omits the specific field names `counterpartyFixedFee` / `gridApiFixedFee` that the other version mentions). Per the "use snippets instead of duplicating content" rule in CLAUDE.md, this content is a good candidate for a shared snippet — e.g. `mintlify/snippets/fee-fluctuation-note.mdx` — so both pages stay in sync automatically.

```suggestion
{/* Consider extracting to mintlify/snippets/fee-fluctuation-note.mdx and importing here */}
<Note>
  Quoted fees may fluctuate between quotes. Some underlying fee components
  are denominated in the receiving currency, so their equivalent in the
  sending currency moves with the FX rate. The fee shown in the quote is
  locked only for the lifetime of that quote — a new quote for the same
  transfer may return a different total.
</Note>
```

**Context Used:** CLAUDE.md ([source](https://app.greptile.com/review/custom-context?memory=21abe025-35ab-4ae8-a4a1-0071c2ac3b98))

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

Comment on lines 89 to +97
<Warning>
Quote expiration depends on the corridor but is typically ~5 minutes or greater. If expired, create a new quote to get an updated exchange rate.
</Warning>

<Note>
Quoted fees may fluctuate between quotes. Some underlying fee components
are denominated in the receiving currency, so their equivalent in the
sending currency moves with the FX rate. The fee shown in the quote is
locked only for the lifetime of that quote — a new quote for the same
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Consider <Warning> instead of <Note> for fee fluctuation

The immediately preceding callout uses <Warning> for quote expiration, which simply causes a request to fail. The fee-fluctuation caveat can silently result in a different charge amount — a developer who doesn't account for it may show users a price that doesn't match the executed transfer. Per the AGENTS.md component guide, <Warning> is for "Critical information about potential issues"; this arguably qualifies more than expiration does. Consider promoting it to <Warning> for visual parity with the adjacent callout and to signal its importance.

Context Used: mintlify/AGENTS.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/snippets/sending/cross-currency.mdx
Line: 89-97

Comment:
**Consider `<Warning>` instead of `<Note>` for fee fluctuation**

The immediately preceding callout uses `<Warning>` for quote expiration, which simply causes a request to fail. The fee-fluctuation caveat can silently result in a different charge amount — a developer who doesn't account for it may show users a price that doesn't match the executed transfer. Per the AGENTS.md component guide, `<Warning>` is for "Critical information about potential issues"; this arguably qualifies more than expiration does. Consider promoting it to `<Warning>` for visual parity with the adjacent callout and to signal its importance.

**Context Used:** mintlify/AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=51934046-75fb-42d3-9870-f42d61cb60e3))

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

@pengying pengying merged commit 668cfaf into main May 18, 2026
8 checks passed
@pengying pengying deleted the claude/laughing-gauss-de7efe branch May 18, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants